Skip to content

Re-enable tests using Client get_projects() #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2024
Merged

Re-enable tests using Client get_projects() #1740

merged 3 commits into from
Jul 23, 2024

Conversation

vbrodsky
Copy link
Contributor

Description

After we reverted my update that was skipping projects with no editors for get_projects, these tests can be re-enabled again

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner July 22, 2024 21:06
vbrodsky
vbrodsky commented Jul 22, 2024
View reviewed changes
libs/labelbox/tests/integration/test_labeling_frontend.py
def test_labeling_frontend_connecting_to_project(project):
client = project.client
default_labeling_frontend = next(
client.get_labeling_frontends(where=LabelingFrontend.name == "Editor"))

assert project.labeling_frontend(
) == default_labeling_frontend # we now have a default labeling frontend
assert project.labeling_frontend() is None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have reverted the back-end change that created a labeling editor automatically

Remove test_labeler_performance.py
809a4c8 
Not possible to test becaues new labeler performance api delays data collection for up to 30 mins
@vbrodsky vbrodsky force-pushed the VB/unskip-get-projects-tests branch 2 times, most recently from 5f1823c to 809a4c8 Compare July 23, 2024 22:04
@vbrodsky vbrodsky merged commit 49b5957 into develop Jul 23, 2024
26 of 27 checks passed
@vbrodsky vbrodsky deleted the VB/unskip-get-projects-tests branch July 23, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfendell-labelbox sfendell-labelbox sfendell-labelbox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbrodsky @sfendell-labelbox